Repository navigation
fix(bundle): encode virtual module names for quoted HTML filenames - #1977
Merged
Lorenzobattistela merged 1 commit intoOct 31, 2026
Merged
Lorenzobattistela merged 1 commit into
Lorenzobattistela merged 1 commit into
Conversation
Lorenzobattistela
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HTML page whose filename contains a double quote fails to bundle an inline module importing Bend: serialization of the generated module
srcchanges the virtual path, and Bun reportsCould not resolve.Encode the page basename in generated inline-module names so it survives HTML attribute serialization. The module keeps its original directory, and diagnostics still point to the source page.
Validation on Linux:
bundle_inlineregression returns9on main and0with this fix; interpreted and emitted-JS runs both pass, independently rerun by the parent agent.git diff --checkpasses.review-agentreview: no findings.The regression uses a JS-only foreign effect. The mini-cluster gate could not start because its hostname did not resolve.