Fsync the parent directory after object rename and delete - #10
Merged
Conversation
sync_data on the tmp inode is not enough. Power-loss after ACK can lose the dirent. Same class as slipstream compact (B7).
sync_data on the inode is not enough. PUT/copy/move/MPU and DELETE must fsync the parent dirent (Pedra F17). Same helper after every rename and successful unlink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUT already
sync_datas the tmp file (B19). The rename dirent is not fsynced. Power-loss after ACK can lose the object (B32) or resurrect a DELETE (B56). slipstream compact already fsyncs the parent (B7 / #14).Two commits: failing PUT test (
DIR_FSYNCSstays 0), thensync_dirafter every rename and successful unlink.