Conditional writes are not atomic; If-Match * is broken - #8
Merged
Conversation
Create-only must have one winner, If-Match is CAS, If-Match * updates an existing object. These fail on current main.
Flock + dest.recheck under the lock (append .lock, do not replace the extension). Treat If-Match * as exists-any-etag. fsync copy_object before rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If-None-Match and If-Match were check-then-rename. Concurrent creates/updates both returned Ok. S3 If-Match * was stored as the literal etag and always 412. Two commits: tests that fail on main, then the fix.
path.lock, notwith_extension).copy_objectfsyncs before rename.git checkout HEAD~1 && cargo test -p beyond-objects-storage --test conditional_writesfails; HEAD passes.