GET of a 0-byte object must not mmap 1 byte - #9
Merged
Conversation
Inclusive-end on size=0 is length 1. HEAD already advertises 0. Darwin mmap fails with EINVAL (500); Linux returns a phantom 0x00.
Full GET uses the exclusive window (0, size), matching S3 GetObject and HEAD Content-Length. size=0 now takes Body::empty() instead of mmap past EOF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REST GET without Range used inclusive-end:
size.saturating_sub(1) + 1. For a legal empty object that is length 1, so we mmap one byte past EOF.HEAD already advertises Content-Length 0. S3 GetObject already uses the exclusive window
(0, size). Darwin mmap fails with EINVAL (500). Linux returns a phantom 0x00.Two commits: failing unit + REST tests, then exclusive full-GET window.
(0, size)viaget_windowlength == 0takesBody::empty()