Update electron-builder to fix macOS release signing - #292
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bholmesdev
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
macOS release builds fail on current GitHub runners because our electron-builder version passes the certificate password to
security set-key-partition-list. Upgrade electron-builder from 26.8.1 to 26.16.1, whose published app-builder-lib package includes the merged and tested upstream fix from electron-userland/electron-builder#10101.The last successful release ran on macOS 26.5.2. GitHub updated the runner image to macOS 26.6.2 on September 1; both release attempts on that image rejected the wrong keychain password.
Type of Change
Testing
Manual Testing Details:
Verified the installed electron-builder version and app-builder-lib password flow, then ran
pnpm build:desktop.Checklist