Skip to content

fix: allow deploy when legacy LiteLLM key is missing #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biersoeckli merged 1 commit into from
Nov 11, 2026
Merged

fix: allow deploy when legacy LiteLLM key is missing #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/server/services/agent-runtime.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,16 @@ class AgentRuntimeService {
const existingSecret = await secretService.getDecodedSecret(secretName, namespace);

if (existingSecret?.QS_VIRTUAL_KEY && agent.llmGateway?.encryptedAdminKey) {
const adminKey = CryptoUtils.decrypt(agent.llmGateway.encryptedAdminKey);
await liteLlmApiAdapter.deleteVirtualKey(
agent.llmGateway.baseUrl,
adminKey,
existingSecret.QS_VIRTUAL_KEY,
);
try {
const adminKey = CryptoUtils.decrypt(agent.llmGateway.encryptedAdminKey);
await liteLlmApiAdapter.deleteVirtualKey(
agent.llmGateway.baseUrl,
adminKey,
existingSecret.QS_VIRTUAL_KEY,
);
} catch (error) {
console.warn(`Failed to delete legacy LiteLLM virtual key during Agent deploy (agentId=${agentId}):`, error);
}
}

await secretService.deleteSecretSafe(secretName, namespace);
Expand Down
18 changes: 18 additions & 0 deletions src/server/services/agent-runtime.service.unit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,24 @@ describe('agent-runtime.service', () => {
vi.mocked(liteLlmApiAdapter.listVirtualKeysByUserId).mockResolvedValue([]);
});

describe('refreshRuntimeSecret', () => {
it('refreshes the secret when the legacy key was already deleted in LiteLLM', async () => {
vi.mocked(dataAccess.client.agent.findUnique).mockResolvedValue(mockAgent() as any);
vi.mocked(secretService.getDecodedSecret).mockResolvedValue({ QS_VIRTUAL_KEY: 'old-key' });
vi.mocked(liteLlmApiAdapter.deleteVirtualKey).mockRejectedValue(new ServiceException('LiteLLM request failed with status 404: No keys found'));
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});

await agentRuntimeService.refreshRuntimeSecret(AGENT_ID);

expect(secretService.deleteSecretSafe).toHaveBeenCalledWith(KubeObjectNameUtils.toSecretId(AGENT_ID), PROJECT.id);
expect(secretService.createOrReplaceGenericSecret).toHaveBeenCalledWith(
KubeObjectNameUtils.toSecretId(AGENT_ID), PROJECT.id,
{ QS_GATEWAY_URL: GATEWAY.baseUrl, MY_KEY: 'my-secret' },
);
warn.mockRestore();
});
});

describe('startSandbox', () => {
it('starts Git source agents after the sandbox template has been deployed', async () => {
vi.mocked(dataAccess.client.agent.findUnique).mockResolvedValue(mockAgent({ sourceType: 'GIT' }) as any);
Expand Down
Loading