Increate test coverage - #12
Merged
Merged
Conversation
ammancilla
force-pushed
the
task/excoveralls
branch
6 times, most recently
from
July 8, 2026 13:39
596c55b to
fa40ce7
Compare
ammancilla
force-pushed
the
task/excoveralls
branch
from
July 8, 2026 13:41
fa40ce7 to
5d969cd
Compare
ammancilla
marked this pull request as ready for review
July 8, 2026 13:54
joelpaulkoch
reviewed
Jul 8, 2026
Member
There was a problem hiding this comment.
We could replace the general tmp helpers with the @tmp_dir tag from ex_unit 🤔
joelpaulkoch
approved these changes
Jul 8, 2026
joelpaulkoch
left a comment
joelpaulkoch
left a comment
Member
There was a problem hiding this comment.
Great test helpers and good to have better coverage. We could think about using the @tmp_dir tag from ex_unit but I'll already approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.