Repository navigation
fix(splice): curate memory floors for Splice 0.9.0 and run CI on catalogue changes - #363
Merged
Merged
Conversation
#353 catalogued 0.9.0 without min/recommended memory. It is the only 0.9 entry, so there was no same-major floor to inherit: the pre-flight gate fell back to the 4 GiB default and the low-memory warning was disabled (RecommendedMemoryFor = 0). TestSpliceMemoryFloors_NeverBelowDockerGate has been failing on main since. Upstream 0.9.0's LocalNet resource-constraints.yaml is identical to 0.8.1's (13 limits, 13.16 GiB total), so use the same 8 GB / 12 GB floors. Add a catalogue test so a newly catalogued major cannot ship without a curated floor again.
CI's path filters only matched Go, frontend and a few doc trees, so the refresh-versions bot PR #353 (versions.json only) ran no Go tests and merged with TestSpliceMemoryFloors_NeverBelowDockerGate failing; the push to main skipped CI for the same reason. versions.json, assets/ and internal/ui/dist/ are all //go:embed inputs to the Go suite, so add them to both the pull_request and push filters. Document that the first entry of a new Splice major needs curated memory floors, which TestEveryCataloguedMajorHasCuratedFloor enforces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
go test ./internal/localnet/fails on main:#353 catalogued Splice 0.9.0 without
min_memory_bytes/recommended_memory_bytes. It is the only0.9entry, so there is no same-major floor to inherit. As a result, forlocalnet up --version 0.9.0(CLI and Web UI pre-flight both usesplice.MinMemoryFor/RecommendedMemoryFor):RecommendedMemoryForreturns 0).This wasn't caught because CI's path filters don't include
internal/splice/versions.json. The bot PR ran only the authorship check, and the merge to main skipped CI as well.What
cluster/compose/localnet/resource-constraints.yamlis identical to 0.8.1's (13 limits, 13.16 GiB total).TestEveryCataloguedMajorHasCuratedFloor: fails when any catalogued major has no entry with both floors set, so a future new major can't ship with the 4 GB fallback.internal/splice/versions.json,assets/**orinternal/ui/dist/**change. All three are//go:embedinputs to the Go tests. The filters are added to both thepull_requestandpushlists, so refresh-versions bot PRs now run the tests above.docs/versions.md: the maintainer flow now says that the first entry of a new major needs the floors.Testing
go test ./...: all packages pass.golangci-lint run(v2.12.2): 0 issues.versions.jsonand passes with this change.TestSpliceMemoryFloors_NeverBelowDockerGatedoes the same.scripts/ci/check-authorship.sh origin/main HEAD: OK.No CLI/Web UI parity change: both surfaces read the same catalogue functions.