Repository navigation
feat(build): fail the build on post markup that runs code - #122
Merged
Merged
Conversation
A post_convert hook parses each rendered post body with an HTML5 parser and rejects active elements, event handler and srcdoc/formaction attributes, and URL attributes with schemes posts do not use. Code blocks are text by then and pass.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_plugins/safe_post_html.rb: apost_converthook that parses each post's rendered body with Nokogiri's HTML5 parser and fails the build on markup that would run code or load a document: active elements (script,object,base,meta,form, ...),on*/srcdoc/formactionattributes, and URL attributes whose scheme is not http(s), mailto, tel, relative, an anchor, or an inline image.Test plan
ruby test/run_all.rb: 192 runs, 0 failures (15 active and 11 safe cases added)bundle exec jekyll build: all 38 existing posts build unchanged<img onerror>fails the build with the post path; the same text in a code span builds