Repository navigation
test: pin the image-probe wiring; hold logger and paths to the domain rule - #30
Merged
Merged
Conversation
bits-bytes-nn
force-pushed
the
refactor/hex-split-main
branch
from
November 1, 2026 01:30
9bc1401 to
9ecc780
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-cleanup
branch
from
November 1, 2026 01:30
ae60bf8 to
f3c4fa4
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-split-main
branch
from
November 1, 2026 01:32
9ecc780 to
a0dcbb9
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-cleanup
branch
from
November 1, 2026 01:32
f3c4fa4 to
e755eab
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-split-main
branch
from
November 1, 2026 01:33
a0dcbb9 to
7f97cb1
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-cleanup
branch
from
November 1, 2026 01:34
e755eab to
8fe5c46
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-split-main
branch
from
November 1, 2026 01:35
7f97cb1 to
cb9fad9
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-cleanup
branch
from
November 1, 2026 01:35
8fe5c46 to
862ce6d
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-split-main
branch
from
November 1, 2026 01:37
cb9fad9 to
bdb2b8b
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-cleanup
branch
from
November 1, 2026 01:37
862ce6d to
aab3ac3
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-split-main
branch
from
November 1, 2026 01:39
bdb2b8b to
76b8979
Compare
bits-bytes-nn
force-pushed
the
refactor/hex-cleanup
branch
from
November 1, 2026 01:39
aab3ac3 to
92ad09e
Compare
Nothing at import time stops a domain module from importing boto3 or an adapter from importing a service, so the layering would erode one stray import at a time. tests/test_architecture.py reads every module under app/domain, app/application and app/adapters with ast and fails on an import that points outward. The one exception is botocore.exceptions in llm_batching.py: the retry classifier has to recognise the SDK errors that langchain_aws re-raises unchanged. design.md now describes the domain/application/adapters tree, the ports and the composition root, and every module path that moved; the READMEs point at the new locations; the CHANGELOG records the restructuring.
… rule The conftest stub of the probe on app.main patched a name nothing reads, and no fixture post carries an image, so dropping every image passed the suite. Replace it with a test that the handler hands the summarizer the real probe. The architecture test now scans app/logger.py and app/paths.py, which the domain imports, and main.py takes its paths from app.paths instead of counting parent directories.
bits-bytes-nn
force-pushed
the
refactor/hex-cleanup
branch
from
November 1, 2026 01:41
92ad09e to
4d2744f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hexagonal restructure, stacked on #29 (merge that first). Pure refactor: the golden snapshot test (delivered HTML, envelope, S3 keys, ledger) passes unchanged at this stage, together with ruff,
mypy app scriptsand pytest with the coverage ratchet.The conftest stub of the probe on app.main patched a name nothing reads,
and no fixture post carries an image, so dropping every image passed the
suite. Replace it with a test that the handler hands the summarizer the
real probe. The architecture test now scans app/logger.py and
app/paths.py, which the domain imports, and main.py takes its paths from
app.paths instead of counting parent directories.