Repository navigation
fix: final review pass — plain-text part, greeting theme, KO chrome, test gaps - #33
Merged
Merged
Conversation
…test gaps
- The text/plain part collapsed every whitespace run, breaking code
indentation and running table cells together; code blocks are kept
verbatim, summary table cells are separated and list items marked. The
golden test now snapshots the plain part too.
- Both test issues' greetings grouped all three articles under "AI
agents" though one was not; a shared theme must now hold for every
article, and the greeting may not reuse a figure from a card lede.
- KO issues get Korean logo alt text, a per-language footer
(`footer_title: {ko, en}`) and Korean image alt text; lists must be
real <ul>/<ol>; counted figures count as computed ones.
- Shortening is one attempt: retries could push a run past the Batch
attempt timeout. The greeter is built inside its failure guard.
- A test formats the real shortening prompt for KO and EN; EN length
comes from EN_LENGTH_BAND; shared helpers lose their underscore; a dead
header field, an unused architecture allowance and f-string logging
(now ruff G004) are gone; CI runs on every PR, stacked ones included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final adversarial pass (three reviewers: pipeline correctness, delivered email, structure/tests/docs). No MAJOR in pipeline correctness; MAJORs fixed: text/plain part broke code and tables, greeting invented a shared theme; test gaps fixed: the real shortening prompt is now formatted in a test and the golden test snapshots the plain part. Verified with ruff, mypy, pytest + coverage ratchet, and a local prod run sent only to the owner (greeting no longer forces a theme; KO alt texts and footer; tables and code readable in the plain part). See the commit message for the full list.