fix(ui): stop showing add/remove favorite notifications in the footer - #440
fix(ui): stop showing add/remove favorite notifications in the footer#440tahadx wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughFavorite toggles no longer display success status messages. Error handling, favorite-state refreshes, list updates, and behavioral test assertions remain. ChangesFavorite toggle notification removal
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Favorite toggles continue to update favorites and surface errors, but no longer show added or removed status-bar messages. The change is ready to merge with no identified current-head risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The add/remove favorite notification is a distraction and there's no need for it. It also caused a footer layout shift I fixed in a separate PR, but that PR was closed in favor of this simpler approach.
Removes the transient status-bar notification (footer row) shown when a track is added to or removed from favorites via
n.favAddedMark/favRemovedMarkmessages from the playlist or playlist-manager handlers.favRemovedStyle,favAddedMark, andfavRemovedMarkdefinitions.