Skip to content

fix(ui): stop showing add/remove favorite notifications in the footer - #440

Open
tahadx wants to merge 1 commit into
bjarneo:mainfrom
tahadx:fix/remove-favorite-notification
Open

fix(ui): stop showing add/remove favorite notifications in the footer#440
tahadx wants to merge 1 commit into
bjarneo:mainfrom
tahadx:fix/remove-favorite-notification

Conversation

@tahadx

@tahadx tahadx commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

The add/remove favorite notification is a distraction and there's no need for it. It also caused a footer layout shift I fixed in a separate PR, but that PR was closed in favor of this simpler approach.

Removes the transient status-bar notification (footer row) shown when a track is added to or removed from favorites via n.

  • Does not post favAddedMark/favRemovedMark messages from the playlist or playlist-manager handlers.
  • Drops the now-unused favRemovedStyle, favAddedMark, and favRemovedMark definitions.
  • Removes the corresponding status-text assertions from tests.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 070771a5-83ae-44a2-b34e-5a679031ba46

📥 Commits

Reviewing files that changed from the base of the PR and between fc9f86d and 14d911a.

📒 Files selected for processing (3)
  • ui/model/dirs_screen_test.go
  • ui/model/keys.go
  • ui/model/view.go
💤 Files with no reviewable changes (1)
  • ui/model/dirs_screen_test.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Favorite toggles no longer display success status messages. Error handling, favorite-state refreshes, list updates, and behavioral test assertions remain.

Changes

Favorite toggle notification removal

Layer / File(s) Summary
Remove favorite toggle notifications
ui/model/keys.go, ui/model/view.go, ui/model/dirs_screen_test.go
Favorite toggles retain error handling and state refreshes but no longer show added or removed notifications. Unused notification markers and related test assertions were removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 14d91

Favorite toggles continue to update favorites and surface errors, but no longer show added or removed status-bar messages. The change is ready to merge with no identified current-head risk.

Suggested reviewers: bjarneo, nfvelten

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing add/remove favorite notifications from the footer.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant