feat: support stream half-close - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests first
The first commit adds four regression tests before the implementation. Against main, all four fail and expose the missing behavior: local shutdown causes premature read EOF, peer FIN rejects replies, one FIN marks the stream fully closed, and Drop after FIN loses the directional lifecycle.
The final branch adds coverage for FIN-before-accept, simultaneous crossed FIN/data, repeated shutdown and Drop emitting one FIN, idle activity refresh, and invalid late PSH handling.
Validation
Closes #8