Repository navigation
IT[TcpBrokerConnection]: remove sleep in testNegotiationFailed - #176
Merged
Merged
Conversation
chrisbeard
approved these changes
Nov 6, 2026
678098
force-pushed
the
261106_testNegotiationFailed
branch
from
November 6, 2026 21:23
23de136 to
3366066
Compare
The test slept 10s before each run. Each run uses its own port, simulator and session, so there is nothing to wait for. Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
261106_testNegotiationFailed
branch
from
November 6, 2026 22:20
3366066 to
0446cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test slept 10s before each run. Each run uses its own port, simulator and session, so there is nothing to wait for.
Should save ~30 seconds from ITs run
Before
After