Repository navigation
Fix[Build]: restore test logging, default to WARN - #177
Merged
Merged
Conversation
chrisbeard
approved these changes
Nov 6, 2026
Logs never showed up when tests ran in CI. slf4j-api 2.x does not support the old log4j-slf4j-impl bridge, which was written for slf4j 1.7. It skipped that bridge and used the no-op logger, so every log call did nothing. Changes: - Switch to log4j-slf4j2-impl, the log4j bridge for slf4j 2.x (sdk tests and examples). - Set the default test log level to WARN. Use -Dbmq.log.level=info (or debug) for more detail. Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs never showed up when tests ran in CI.
slf4j-api2.x does not support the oldlog4j-slf4j-implbridge, which was written forslf4j1.7. It skipped that bridge and used the no-op logger, so every log call did nothing.Changes:
log4j-slf4j2-impl, thelog4jbridge forslf4j2.x (sdk tests and examples).-Dbmq.log.level=info(or debug) for more detail.Before
After