Repository navigation
CI: Avoid rebuilding the test extension twice - #129
Open
pniedzielski wants to merge 1 commit into
Open
pniedzielski wants to merge 1 commit into
pniedzielski wants to merge 1 commit into
Conversation
The Linux test job builds the Cython extension twice: first with the Makefile target `test-build`, and then again immediately after during the editable installation in `test-install`. They are both built with the same Cython test settings, and so there is no benefit to having both. This patch changes our Linux test job to run `test-install` followed by `check`, which avoids this redundant build. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
ci/remove-redundant-test-build
branch
from
November 10, 2026 20:36
b6212a0 to
3c83ac6
Compare
pniedzielski
added
skip news
chrisbeard
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux test job builds the Cython extension twice: first with the Makefile target
test-build, and then again immediately after during the editable installation intest-install. They are both built with the same Cython test settings, and so there is no benefit to having both.This patch changes our Linux test job to run
test-installfollowed bycheck, which avoids this redundant build.