Repository navigation
When using IDN domain names, it is easy to reach the limit and throw exception Regex::DOMAIN_OR_SUBDOMAIN #1
Description
Activity
Thank you very much for notifying.
Let's increase it to 255.
What do you think?I'm on it.
Thank you very much for notifying. Let's increase it to 255. What do you think?
Perhaps okay, but why there's a limitation for hostname length?
Hello
This domain is valide xn--c1aafynu.xn--c1avg.xn--p1acf, but the regex doesn't match
because the xn part is not in the TDL -> ^(([\w\d_-]+){1,63}.)+([\w\d_-]+){2,63}$Why the lib, don't use https://www.php.net/manual/en/filter.filters.validate.php
Reacted by Bruce Lam@xiaohuilam can you test #3 ?
@xiaohuilam can you test #3 ?
@james2001 I think this is better.
filter_var($hostName, FILTER_VALIDATE_DOMAIN)
because it will return false if
$hostName = '_dnsauth.test.com'in your code:$hostName = '_dnsauth.test.com'; var_dump(filter_var($hostName, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)); // it returns `false`, and unexpected.
_dnsauthis digicert's domain validation hostname prefix, it's allowed to be created as dns host for mostly dns service providers.and, please mention @bluelibraries for more review because he is the owner of this repository.
@xiaohuilam I fix it, but un didn't understand. _dnsauth.test.com is not a valide hostname (RFC 1034 et 1035).
Perhaps rename the method, to be more explicite_dnsauth.test.com is not a valide hostname (RFC 1034 et 1035)
_dnsauthis the solid dns hostname implemented by DigiCert (a ssl certificate authority) which using to validate(DNS method) domain names, I found this bug when i tried your PR at my SSL reselling project.Reacted by Rathgeber Stéphane
dns/src/Handlers/AbstractDnsHandler.php
Lines 98 to 103 in 92208ec