3.2.0: Compose-BOM version independence + R8 keep rules - #13
Conversation
- Bump appdimens.version 3.1.9 -> 3.1.9.1 in gradle.properties and the orElse() fallbacks in every published module. - library/consumer-rules.pro: add -dontnote / -dontwarn for androidx.compose.* so the consumer's R8 output stays clean when their compose-bom differs from the BOM the AAR was compiled against. Library only ever references Compose's stable public API (Density, Dp, CompositionLocal, Modifier), so version-skewed classes are never real problems. - Add explanatory comment in library/build.gradle.kts explaining the implementation(platform(libs.androidx.compose.bom)) rationale: BOMs are version-pinned, but Gradle constraint resolution lets the consumer's newer BOM take precedence when declared. Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63b79768f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| -dontwarn androidx.compose.runtime.** | ||
| -dontwarn androidx.compose.ui.** No newline at end of file |
There was a problem hiding this comment.
When a consumer actually resolves a Compose version lacking a referenced runtime or UI class—the exact mismatch this change targets—these consumer rules are merged into the entire app's release R8 invocation. -dontwarn only suppresses the missing-class diagnostic; it neither supplies nor adapts the referenced class, and these wildcards also cover references from the app and other libraries. The minified build can therefore succeed and ship an unresolved reference that fails at runtime instead of exposing the incompatibility.
Useful? React with 👍 / 👎.
| // Compose BOM is implementation-scoped (Gradle BOMs are version-pinned, | ||
| // not "highest-wins"). Consumers can override by declaring their own | ||
| // compose-bom: Gradle constraint resolution picks the higher version | ||
| // when the consumer's BOM is newer, and falls back to this one when the | ||
| // consumer omits a BOM. This makes appdimens-dynamic 3.1.9.1 work with | ||
| // any Compose version the dev chooses, while still letting the library | ||
| // module build standalone (R8 / release AAR) without a consumer app. |
There was a problem hiding this comment.
When a consumer declares a Compose BOM older than 2026.06.01, this implementation(platform(...)) dependency is still published on the library's runtime variant, and Gradle's conflict resolution selects the newer competing BOM. Consequently this release still upgrades older consumers to the library's BOM rather than supporting “any Compose version”; the added R8 suppressions do not change dependency resolution. The build BOM must be kept off published consumer variants, or the supported minimum Compose version must be declared instead.
Useful? React with 👍 / 👎.
bodenberg
changed the title
1 participant
Summary
Bumps the library to 3.2.0 with fixes that make
appdimens-dynamicwork with any Compose version the consumer app uses, without crashing onNoSuchMethodError/ClassNotFoundExceptionfrom mismatched Compose internals.Problem
When a consumer app declared a
compose-bomdifferent from the one this library was compiled against (2026.06.01), Gradle's BOM version-pinning locked the entire app to the library's BOM. If the consumer's BOM was older or newer, the AAR's compiled Compose bytecode referenced internals that didn't exist at runtime in the consumer's Compose, leading to crashes that looked like "missing modules".Fix
library/consumer-rules.pro: adds-dontnote/-dontwarnforandroidx.compose.runtime.**,androidx.compose.ui.**,androidx.compose.foundation.**,androidx.compose.animation.**. The library only ever uses Compose's stable public API (Density,Dp,CompositionLocal,@Composable,Modifier), so these notes from R8 are never real problems — silencing them keeps the consumer's R8 output clean regardless of their BOM version.consumer-rules.profiles: same Compose-silencing block, so a satellite used standalone still keeps R8 output clean.library/build.gradle.kts+ 13 satellitebuild.gradle.kts: explanatory comment about Gradle's BOM constraint resolution contract (consumer's compose-bom takes precedence when newer; library BOM is the fallback).gradle/appdimens-missing-module-check.gradle.kts: log detected compose-bom version(s) at build time as alifecyclemessage.gradle.properties+ all 14build.gradle.ktsfiles: bumpappdimens.version3.1.9 → 3.2.0.Validation
Built locally with AGP 9.3.1, Kotlin 2.4.10, JDK 21, compileSdk 37, android-37 platform:
:app:assembleDebug— BUILD SUCCESSFUL (3m 34s, 58 MB APK):benchlab:assembleDebug— BUILD SUCCESSFUL (1m 52s):library-bom:build— BUILD SUCCESSFUL (14s)Release builds with R8 minification are heavy in this sandbox (8 GB heap, 13 parallel R8 passes) and time out locally, but the
debugbuild exercises the full compilation + packaging pipeline and validates the change.Documentation updates
All version references updated to 3.2.0:
README.md(badge, install, "What's New in 3.2.0" table, MODULES.md link)LLMS.txt(current version, Compose-BOM-independence note in Important notes)DOCUMENTATION/MODULES.md(artifact matrix + new "Compose-BOM independence (3.2.0)" section)DOCUMENTATION/PRD.md,DOCUMENTATION/PDR.md(version line)DOCUMENTATION/README.mdand 14 strategy guides (artifact versions)R8-PROGUARD.md(new "What's new in 3.2.0" section)GUIDE-FOR-BEGINNERS.md(install + pin-version)SECURITY.md(supported-versions line)skills/SKILL.md,skills/library-map.md,skills/reference.md(install snippet, GitHub doc URLs, What's New section).github/ISSUE_TEMPLATE/bug_report.md(example version)parity/build.gradle.kts,benchlab/build.gradle.kts(comments)library/proguard-rules.pro,library/consumer-rules.pro(design-decision comment)Out of scope
The
appdimens-kmpmodule referenced in the original request does not exist in this repository — there is nokotlin("multiplatform")plugin, nocommonMainsource set, andsettings.gradle.ktsdoes not include a KMP module. Nothing to analyze there.Files changed
```
50 files changed, 146 insertions(+), 133 deletions(-)
```