Skip to content

Fix namespace used for hip integration, update hip and cuda examples - #345

Open
m-fila wants to merge 8 commits into
boostorg:developfrom
m-fila:cuda_hip
Open

Fix namespace used for hip integration, update hip and cuda examples#345
m-fila wants to merge 8 commits into
boostorg:developfrom
m-fila:cuda_hip

Conversation

@m-fila

@m-fila m-fila commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
  • The integration with HIP was using boost::fiber::cuda namespace instead of boost::fiber::hip.
  • The HIP examples were using very old HIP syntax (hipLaunchKernel instead of triple-chevrons or hipLaunchKernelsGGL, mandatory hipLaunchParm in kernels). I couldn't easily pinpoint the version of HIP which stopped supporting the old syntax, I propose to use the more modern version without checking compatibility with preprocessor.
  • Both integration headers and examples had many unneeded headers.
  • The extension of of files with HIP kernels was changed to .hip from .cpp
  • Changed path to hipccc to /opt/rocm/bin as it appears to be used nowadays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant