Skip to content

[hawick] Support passing std::reference_wrapper to boost::hawick_circuits#536

Merged
Becheler merged 3 commits into
boostorg:developfrom
ldionne:ldionne-ref-wrapper
Jul 21, 2026
Merged

[hawick] Support passing std::reference_wrapper to boost::hawick_circuits#536
Becheler merged 3 commits into
boostorg:developfrom
ldionne:ldionne-ref-wrapper

Conversation

@ldionne

@ldionne ldionne commented Jul 20, 2026

Copy link
Copy Markdown
Member

@ldionne

ldionne commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

This supersedes #249 which I can't modify anymore for some reason.

@cppalliance-bot

cppalliance-bot commented Jul 20, 2026

Copy link
Copy Markdown

An automated preview of the documentation is available at https://536.graph.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-07-21 12:17:20 UTC

@ldionne

ldionne commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

@Becheler I created this PR from my own fork, so you can clean up any branches on the boostorg repo if desired.

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 29829351974 vs develop run 29738450065 (81ac21073b).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 68 → 68 (0)

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 29829351972 vs develop run 29738450095 (81ac21073b).

Job Baseline After Delta
macos (clang, 14) 4 4 0
macos (clang, 17) 4 4 0
macos (clang, 20) 4 4 0
ubuntu (clang-19, 14) 4 4 0
ubuntu (clang-19, 17) 4 4 0
ubuntu (clang-19, 20) 4 4 0
ubuntu (clang-19, 23) 4 4 0
ubuntu (gcc-14, 14) 10 10 0
ubuntu (gcc-14, 17) 10 10 0
ubuntu (gcc-14, 20) 10 10 0
ubuntu (gcc-14, 23) 10 10 0
windows_msvc_14_3 (msvc-14.3) 971 971 0

@Becheler Becheler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than just an obsolete guard, I think this is good to go ?
Thank you so much for your reactivity Louis ! 🙏🏽
Good to finally interact after seing your name everywhere ahahaha ❤️

Comment thread include/boost/graph/hawick_circuits.hpp Outdated
Comment thread test/hawick_circuits.cpp Outdated
@Becheler Becheler added the algorithm type of issue related to algorithms label Jul 20, 2026
@jeremy-murphy

Copy link
Copy Markdown
Collaborator

Other than just an obsolete guard, I think this is good to go ?
Thank you so much for your reactivity Louis ! 🙏🏽
Good to finally interact after seing your name everywhere ahahaha ❤️

Thanks for refreshing your PR, @ldionne. The only other modernization I would make right now is to use = delete on that copy constructor instead of making it private. Everything else I think we can do in a batch one day.

@ldionne

ldionne commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

Comments applied, thanks for the review and for the kind words!

@Becheler
Becheler self-requested a review July 21, 2026 13:55
@Becheler
Becheler merged commit d10a63b into boostorg:develop Jul 21, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm type of issue related to algorithms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants