refactor: drop direct dependency on Boost.SmartPtr#537
Merged
Becheler merged 1 commit intoJul 21, 2026
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in):
Transitive Boost modules: 68 → 68 (0) |
|
Compiler-warning counts vs
|
Becheler
force-pushed
the
refactor/modernize-internal-smart-ptr
branch
3 times, most recently
from
July 21, 2026 05:45
41463af to
3c92750
Compare
Becheler
force-pushed
the
refactor/modernize-internal-smart-ptr
branch
from
July 21, 2026 06:17
3c92750 to
4787113
Compare
Becheler
marked this pull request as ready for review
July 21, 2026 06:50
jeremy-murphy
approved these changes
Jul 21, 2026
jeremy-murphy
left a comment
Collaborator
There was a problem hiding this comment.
Very minor request, so I'm approving now.
Becheler
force-pushed
the
refactor/modernize-internal-smart-ptr
branch
from
July 21, 2026 10:20
4787113 to
ca4c9df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General hygiene related to Boost.SmartPtr
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
r_c_shortest_paths_labelbaseboost::enable_shared_from_this.shared_from_this()was never called.shared_ptr<label>that dereferenced the pointer to sort (by label). Withstd::shared_ptrthose would compete with STL comparison (by pointer).splabel_greaterfunctor for thepriority_queue, and a lambda forlist::sort.Motivation
Boost.SmartPtr does not have heavy dependencies (config, assert, throw_excpetion and core), but dead includes and C++14 STL is proper hygiene: https://github.com/cppalliance/cppalliance.github.io
Testing
Unchanged tests in CI
Checklist
b2in thetest/directory).