Repository navigation
Preserve reference alternatives during rvalue visitation - #118
Open
trestoncuzzort wants to merge 1 commit into
Open
trestoncuzzort wants to merge 1 commit into
trestoncuzzort wants to merge 1 commit into
Conversation
Unwrap reference content through a non-moving visitor so temporary variants retain lvalue references to externally owned objects. Preserve recursive unwrapping and owned-value moves. Fixes boostorg#73. Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73.
Visiting a temporary
variant<T&>currently passes the referenced object as an rvalue. A visitor acceptingT&then fails to compile, and a visitor taking its argument by value can move from an externally owned object.Unwrap reference alternatives through a non-moving
invoke_visitor. This preserves their lvalue category, including through recursive wrappers. Owned alternatives retain their existing move behavior.The regression covers member/free visitation, const containers and referents, mutation and identity, owned-value moves, nested recursive wrappers, binary/multi visitation, and inferred visitor results.
Validation:
Implemented and tested with Codex assistance.