DNM: Several CI adjustments#98
Open
alicefr wants to merge 6 commits into
Open
Conversation
Simplify the GHA job and merge everything in the integration-test.yml to avoid duplication. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Change the support version to print once all the version and onece the non default versions. The non-default version is used by the k8s-versions integration tests which run a subset of the tests. The all-versions will be used by the node image build matrix job in the next commit. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Add changes detection to the node-images/fedora/**. This triggers the build of the node images. Remove of build-node-image.yaml. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Allows callers to pass a node image to pull. When omitted (image already loaded locally from artifact), setup-bink skips pulling it. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Remove per-job overrides and the node image from BINK_IMAGES. The node image will be added dynamically by setup-bink via the node-image input. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
When build-node-images runs, test jobs download and load the artifact instead of pulling from GHCR. When skipped, setup-bink pulls the published image via the node-image input. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add some clean up and tries to merge the GHA running the integration tests into a single file. However, its main focus is to run the integration tests for building the image BEFORE push the images.
The integration tests if there is no change under
node/fedora/*, they use the default bink image, otherwise the CI build s the image and use that instead in the tests.The first commit focus to merge the composefs integration tests together with the other functional tests in order to avoid duplication.