fix: a 3-D reference whose last sheet is TRUE or FALSE is not lexed as a reference - #60
Open
gthb wants to merge 1 commit into
Open
fix: a 3-D reference whose last sheet is TRUE or FALSE is not lexed as a reference#60gthb wants to merge 1 commit into
gthb wants to merge 1 commit into
Conversation
Alpha:TRUE!A1 came out as a name, a colon, a boolean and a bare cell, so no reference formed and fixRanges left it as written. Excel reads it as the sheet range Alpha:TRUE and stores it quoted whole. parseA1Ref already read the sheet range; only the formula lexers disagreed. lexBoolean now yields to a following ! when a colon precedes the word. Alone, TRUE!A1 is still a boolean, and TRUE:Gamma!A1 still no sheet range; Excel refuses both spellings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lex
Alpha:TRUE!A1andAlpha:FALSE!A1as one reference. They came out as a name, a colon, a boolean and a cell, sofixRangesleft them as written, where Excel reads the 3-D reference over the sheetsAlphatoTRUEand stores it quoted whole,'Alpha:TRUE'!A1.parseA1Refalready read it that way; only the formula lexers disagreed.lexBooleanno longer lexesTRUEorFALSEas a boolean when a colon precedes the word and a!follows it, leaving it to the context lexer as the sheet name.TRUE!A1with no colon before it is still a boolean, andTRUE:Gamma!A1is still not a 3-D reference; Excel refuses both spellings.