test: 3-D reference whose end sheet name starts with a column ID - #61
Open
gthb wants to merge 1 commit into
Open
test: 3-D reference whose end sheet name starts with a column ID#61gthb wants to merge 1 commit into
gthb wants to merge 1 commit into
Conversation
Add tests checking that Jan:Bar_Baz!B2 is the sheet range Jan:Bar_Baz, stored unquoted, and is that same sheet range after a range colon.
gthb
changed the title
gthb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests checking that a 3-D reference whose last sheet name only opens with a column ID (
Jan:Bar_Baz!B2, whereJan:Barlooks like a column range):JantoBar_BazfixRanges, which drops whole-range quotes, as Excel doesA1:Jan:Bar_Baz!B2), rather than the column rangeA1:JanA_,A0U,C0C,AÄlandMärare covered alongside. All of this was already correct, just didn't have test coverage.