Add minDecimals to output of getFormatInfo() - #79
Open
yelper wants to merge 2 commits into
Open
Conversation
Owner
|
I like the change but I'm doing a TS rewrite so I've just created major conflicts on this branch. Sorry about that. You'll need to update this patch against the new code. I'd prefer if you didn't include build results (API.md or dist/*) in the PR; they will get produced when a release happens. |
Author
|
Will do! No worries about conflicts, I'm happy to resolve. |
yelper
force-pushed
the
dev/alsarika/add-min-decimals-info
branch
from
September 4, 2026 22:25
afb9488 to
6fda0a2
Compare
Author
|
Updated to match refactor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when I was trying to use
getFormatInfo()to get metadata about formats that "0.0" and "0.#", the info function returned the exact sameFormatInfoobjects.To differentiate them, I thought it was natural to support a
minDecimalsproperty as part ofFormatInfo. This PR adds the ability to return this metadata.Supporting something like
minDecimalswould help pass correct downstream information to other functionality, like compaction of numbers using something like Intl.NumberFormat, settingminimumFractionDigitsandmaximumFractionDigits(see MDN).AI note: I used GPT 5.4 Sol to initially author the PR, but then personally reviewed all code/doc changes.