Skip to content

GTSAM_EXPORT consistency implementation #436

Description

@kshaji3

We are trying to bring this repository in-line with GTSAM's export requirements for Windows DLLs. We need a PR to more uniformly implement the GTSAM_EXPORT keyword across the repository.

See: (from Prof. Frank Dellaert)
The new public classes and free functions should be annotated with GTSAM_EXPORT so they are exported correctly from shared-library builds on Windows. The GTSAM contributing guide documents the required pattern here: https://gtsam.org/notes/contributing/#using-gtsam-export

More detail here: https://github.com/borglab/gtsam/blob/6c59503fea13bb9025b4f098bb3412e57b3531c2/Using-GTSAM-EXPORT.md

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions