Skip to content

Fix Python dependency compatibility - #439

Merged
kshaji3 merged 1 commit into
masterfrom
codex/python-dependency-compatibility
Sep 2, 2026
Merged

kshaji3 merged 1 commit into
masterfrom
codex/python-dependency-compatibility

Conversation

@dellaert

Copy link
Copy Markdown
Member

Why

GTDynamics currently requires numpy>=2.0.0 while accepting gtsam>=4.2. Those constraints are unnecessarily restrictive and can also be internally inconsistent: GTSAM 4.2 wheels were constrained to NumPy 1.x, while current GTSAM 4.3 supports both NumPy 1.x and 2.x.

This change:

  • relaxes the NumPy requirement to the same supported lower bound used by current GTSAM, numpy>=1.11.0;
  • raises the GTSAM requirement to gtsam>=4.3a0, avoiding the older 4.2 wheel line that was pinned below NumPy 2.

This lets pip retain a compatible NumPy 1.x installation instead of reporting a false conflict or forcing an unnecessary NumPy 2 upgrade.

Verification

  • CMake configuration completed successfully.
  • The native GTDynamics library compiled successfully.
  • pip install --dry-run . resolved successfully with NumPy 1.26.4 and GTSAM 4.3a2.
  • The Python test target could not start locally because the installed gtwrap is older than the latest GTDynamics wrapper template (KeyError: 'declaration_module_def'); this is unrelated to the dependency metadata change.

@kshaji3, could you please check out this branch locally and make sure the wrapper and test suite still work in your setup?

@dellaert
dellaert requested a review from kshaji3 August 26, 2026 21:26
@dellaert
dellaert marked this pull request as ready for review August 26, 2026 22:40

@kshaji3 kshaji3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reran all the installations in my local checkout, I have no issues.

@kshaji3
kshaji3 merged commit 0fa75dc into master Sep 2, 2026
6 checks passed
@kshaji3
kshaji3 deleted the codex/python-dependency-compatibility branch September 2, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants