Conversation
| return [path.relative_to(root) for path in root.rglob("*") if path.is_file()] | ||
|
|
||
|
|
||
| def detect_dataset_format(root: Path) -> dict[str, Any]: |
Collaborator
There was a problem hiding this comment.
what is this for? I dont think we should depend on folder structure, and should pipe the config through which contains the name of the loader.
akshay-krishnan
marked this pull request as ready for review
September 1, 2026 18:51
Refactor loader and images directory handling for clarity.
Removed format detection from dataset inspection response.
akshay-krishnan
added this pull request to stack #1146
September 18, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect uploaded and sample dataset layouts, then configure the matching loader automatically.
Changes
Why
GTSFM sample datasets use different directory layouts. Requiring users to know the exact loader and path arguments made the Studio workflow unnecessarily error-prone.
Validation
git diff --checkpassedStack
Depends on #1127 and targets
studio/runtime-reliabilityso this remains a focused, reviewable change.