Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio currently defaults to a separately published GTSFM runtime image, even though its Modal definition can build the environment directly from the project lockfile. Remove the custom Dockerfile and image-publishing workflow, and use the existing Modal build path for deployments.
Removes the custom-image setting, image-pull retry fallback, and prebuilt/source UI labels. Updates the deployment documentation and rebuilds the shipped frontend bundle. Adds coverage for deployment success, failed builds, and loading the real Modal app definition locally.
This PR targets
studio/package-clito remove the custom-image setup from #1121 before that PR merges. The publishing-only #1122 becomes redundant once the stack is updated; it is not closed by this PR.Validation: 39 visualization tests passed; changed Python files passed Flake8;
pnpm buildpassed TypeScript checking and rebuilt the assets;git diff --checkpassed. No live Modal deployment or CUDA reconstruction was performed.