Repository navigation
Merge shorthand classes when the attribute map has no :class - #18
Merged
Merged
Conversation
`merge-attrs` only merged the shorthand classes from a tag like
`:div.card` when the attribute map ALSO carried a `:class` key — the
outer `if-let` tested the map's class, not the shorthand's. So
[:div.card {:id "a"}] => <div id="a"></div>
silently lost the class, while
[:div.card {:class "big"}] => <div class="card big"></div>
worked.
The same expression also interpolated at macroexpansion time, so a
`:class` bound to anything non-constant rendered the symbol's NAME:
(let [x "big"] [:div.card {:class x}]) => class="card x"
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge-attrsonly merged the shorthand classes from a tag like:div.cardwhen the attribute map ALSO carried a:classkey — the outerif-lettested the map's class, not the shorthand's. Sosilently lost the class, while
worked.
The same expression also interpolated at macroexpansion time, so a
:classbound to anything non-constant rendered the symbol's NAME: