Repository navigation
fix(cashier): vales en estado final, alta de vales atómica y totales con permiso - #20
Merged
Conversation
…totals - cashier-voucher-repository.ts: only a pending voucher can change its amount, reason or notes, be justified or be cancelled; the write itself checks the status. createForShift locks the shift, counts its vouchers and creates and links the new one in one transaction; create, canAddVoucherToShift and associateWithShift go. - cashier-voucher-controller.ts: create uses createForShift and answers domain errors with their status. - cashier-errors.ts: the new voucher errors. - cashier-routes.ts: GET /daily, /shifts/:id/history and /vouchers/stats require canViewReports, like the other history and report routes. - voucher-lifecycle.test.ts: transitions, the locked creation, the limit and the three guarded routes. Why: a cancelled voucher could be justified, a justified one cancelled and the amount of either changed; the 5-voucher limit could be passed in parallel and going over it left a voucher without a shift; reception saw history and totals meant for admin. Decided on 2026-10-11: justified and cancelled are final. Checked with curl against the local database: reception gets 403 on the three routes and admin 200; a justified voucher refuses a new amount, cancel and justify; a voucher on a missing shift answers 404 and creates nothing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios
/daily,/shifts/:id/historyni/vouchers/stats(canViewReports).Por qué
Se podían editar vales cerrados, pasar del límite con altas simultáneas y ver totales sin permiso.