Repository navigation
fix(checklist): comentarios y fotos de un día cerrado solo los toca admin - #21
Merged
bpstack merged 1 commit intoOct 12, 2026
Merged
Conversation
- checklist-comments.repository.ts: findComment returns the author, the run and whether the run is closed; findAttachment also says if its run is closed; deleteComment only deletes. - checklist-comments.service.ts: removeComment and removeAttachment answer deleted, not_found, forbidden or closed. On a closed day only admin deletes; the event is logged in the item's own run, not in today's. - checklist-comments-controllers.ts: 404, 403 or 409 for each refusal. - closed-day-deletes.test.ts: closed day, admin, author on an open day, unknown id. Why: the author could delete comments and photos of a closed day, rewriting its history, and the deletion was logged in today's run. Decided on 2026-10-11: only admin deletes on a closed day. Checked with curl against the local database: after closing the day, reception gets 409 and admin deletes the comment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios
Por qué
Recepción podía alterar lo registrado en un día ya cerrado. Decidido el 2026-10-11.