Repository navigation
fix(security): registrar decisiones de autorización y sacar los valores SQL del log - #24
Merged
Conversation
… the log - Log every 403 the API answers (user, role, method and path without the query string) from one middleware before the routes. - Log each time an admin reads, lists or deletes conversations or messages they are not in. - Hide err.sql, and passwords and tokens at the first three levels of each entry instead of only the second. - Document what the log keeps, and that failed logins keep the typed username (owner's decision). No 403 left a trace, nor did an admin reading conversations of others (ASVS 7.2). The SQL of a failed db.query carries its values interpolated, and `*.password` missed req.body.password and a top-level password.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios
access_denied(usuario, rol y ruta); también los accesos de admin a conversaciones ajenas.Por qué
Los 403 no se registraban y los errores de BD escribían en el log los valores de las consultas.