fix: forward Launchable base image - #433
Draft
sandl99 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Forward
createWorkspaceRequest.imageIdfrom a Launchable response to theworkspace creation request as
baseImage.The regression coverage now checks both the populated
CreateWorkspacesOptions.BaseImagefield and the serializedbaseImageJSONfield.
Why
LaunchableWorkspaceRequestalready deserializes the API'simageId, butapplyLaunchableWorkspaceRequestdid not copy it intoCreateWorkspacesOptions.BaseImage. As a result,brev create --launchablesilently dropped a Launchable's custom VM image and the workspace could boot
from the default image instead.
This surfaced in the NemoClaw staging E2E when the workspace created
successfully but did not contain the image-baked
/etc/nemoclaw/provision.jsonreceipt:Validation
gofmt -d pkg/cmd/gpucreate/gpucreate.go pkg/cmd/gpucreate/gpucreate_test.gogo test ./pkg/cmd/gpucreateBoth ran with Go 1.25.
Manual follow-up after merge
This client fix is necessary but is not sufficient for the current NemoClaw
Launchable because its stored
createWorkspaceRequestdoes not currentlycontain an
imageId.Release a Brev CLI version containing this change.
In the Brev Console or Launchables API, create or update the standing
NemoClaw staging Launchable so its
createWorkspaceRequest.imageIdis:Confirm through the Launchable configuration/API response that
imageIdis present.
brev create --dry-rundoes not currently expose the selectedimage, so it is not sufficient for this check.
Create a disposable workspace using the new CLI release and Launchable.
Verify:
/etc/nemoclaw/provision.jsonexists./opt/nemoclaw-image/NemoClawexists.Update the NemoClaw workflow's pinned Brev CLI version and SHA-256 checksum
to the release containing this fix.
Manually update the NemoClaw repository variable
NEMOCLAW_STAGING_LAUNCHABLE_IDonly after the replacement Launchable haspassed the probe above.
Dispatch the trusted full NemoClaw E2E and verify provisioning, checkout,
test, and cleanup evidence.
This PR intentionally does not change
NEMOCLAW_STAGING_LAUNCHABLE_ID.