fix: preserve governed executor failure evidence through Agno - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 53 — preserve governed failure provenance through Agno
This phase closes one concrete framework-boundary gap introduced after structured executor-failure evidence became application-owned.
Concrete gap
The Agno mutable action
Stepalready usesmax_retries=0and fail-closed error handling, butAgnoGovernedActionRuntimetranslatedRunStatus.errorinto a new genericRuntimeError. That discarded the originalGovernedActionExecutionErrorboundary even though the executor had already been invoked and the application runtime had produced structuredActionExecutionFailureEvidence.Design
GovernedActionExecutionErrorinside the adapter-private Agno Step bridge;max_retries=0,skip_on_failure=False, and fail-closed Agno behavior unchanged;RunStatus.error, re-raises the original governed exception rather than synthesizing a generic wrapper;RuntimeErrorhandling for non-governed Agno failures;Security invariants
framework orchestration error status != governed failure evidence loss;mutable executor failure through Agno -> exactly one execution attempt + original governed failure provenance;RunStatus.error != authority or side-effect truth;external_side_effect_state=unknownremains unchanged.Regression evidence
The dedicated Agno regression requires:
GovernedActionExecutionError;ActionContextsurvive;execution_attempted=true;failure_reason=executor_error;external_side_effect_state=unknown;str(error);RuntimeErrorremains only as__cause__.CI
Functional CI #480 passed on
cea0d2e0e5b57c8503e423265f89eed96bb774c9before documentation.Final clean CI #484 passed on
fafc5aea0ca666d0abd5dbd07c89689262d83dceafter documentation and removal of all temporary workflows.The clean run passed:
Documentation
CHANGELOG.mdrecords Agno failure-provenance hardening and evidence;docs/security/GOVERNED_AGENT_ACTIONS.mdnow distinguishes retry suppression from preservation of typed application failure provenance.Final scope
The final diff is limited to:
src/agentic_lab/adapters/agno/action_workflow.py;tests/unit/adapters/agno/test_agno_action_workflow.py;CHANGELOG.md;docs/security/GOVERNED_AGENT_ACTIONS.md.No temporary workflow remains. No application-runtime, policy, dependency, authentication, MCP, historical artifact, or published-release change is included. This phase adds no automatic retry, idempotency, rollback, compensation, two-phase commit, or transaction semantics.
Closes #186