feat: govern and harden service operations - #383
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ty-everett
left a comment
There was a problem hiding this comment.
Substantive maintainer review by ty-everett on exact head a048d6d against unchanged base b512122.
Reviewed the 70-file final diff and production impact. The service registry exactly covers the seven governed containers; the hosted operational check validates health/readiness contracts, non-root images, digest-pinned sample workloads, secret indirection, probes, resource limits, seccomp, dropped capabilities, read-only filesystems, and disabled service-account token mounting. The Overlay, WAB, Storage, and other public-service defaults remain wildcard credential-free CORS; allowlisting remains an explicit operator choice.
Security review confirms Firebase credentials are parsed as data rather than executed, secret-shaped deployment literals are rejected, and UHRP secret synchronization avoids ambient PATH lookup and shell execution while using a private 0600 temporary file with guaranteed cleanup. No new override, dismissal, suppression, skipped test, checked-in Secret, or mutable application image was introduced.
All 65 hosted checks pass on this exact head: both CodeQL analyses, SonarCloud with 0 new issues / 0 hotspots / 0.0% new duplication, dependency review, Socket, Codecov patch coverage, frozen build/lint/typecheck/policy, all seven affected service jobs, docs/codegen/conformance, browser/mobile, full coverage, every mutation shard and mutation-quality aggregate, and the final merge gate. Local repository health is 65/65 with zero contract findings, all seven service audits report zero high/critical vulnerabilities, and the two UHRP service suites pass 43 tests.
No npm package, tag, release, image, or deployment was published. Candidate service versions remain source-only; first-party dependency alignment waits for separately authorized coordinated publication. The deliberately deferred final QA/fuzz/manual/browser/performance program remains tracked rather than being smuggled into this operational wave.
GitHub does not permit an author to formally APPROVE their own pull request, so this COMMENT review records the maintainer acceptance evidence for an exact-SHA admin merge. No unresolved review threads or requested changes remain.



Program and scope
Impact
Affected services and intended patch versions (source candidates only; this PR does not publish):
The next first-party dependency ranges are intentionally not installed yet because those versions are not published. Their release order and lock refresh remain a separately authorized publication-phase dependency.
What changes
governance/service-operations.jsonas the exact seven-service operational contract and adds generated reference documentation plus CI-backed validation.Verification
pnpm health:check: 65/65 controls, zero documentation-policy findings, zero repository-health findingsgit diff --check: passedLocal
pnpm codegen:checkcould not complete because this workstation lacksuv; generated specifications and artifacts are untouched, and the dedicated hosted gate installs the pinned toolchain.Security and dependencies
No dependency versions are changed in this wave; lockfiles change only with the seven candidate package versions. Credential parsing and deployment policy receive direct negative validation, while hosted CodeQL remains authoritative for the complete query set.
Release and operations
No tag, release, image, deployment, or other publication action is authorized or performed here. Kubernetes examples continue to reference currently published exact image digests rather than unpublished source candidates.
Completion evidence