Repository navigation
fix: restore interface language switching - #50
Merged
Merged
Conversation
🤖 Open Code Review — Blockers & Critical onlyModel No blocking issues 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.lprojfolders in the generated app bundle.Root Cause
The app persisted the selected interface language and posted change notifications, but the generated Xcode project did not copy the
en,ja,zh-Hans, orzh-Hantlocalization folders intoVoily.app.AppLocalizationcould not findLocalizable.strings, so UI strings fell back to the source keys after switching languages.Validation
make test-apppassed: 97 tests, 1 native SenseVoice smoke test skipped by environment.make test-corepassed: 77 tests.