Repository navigation
fix(browser): 修复区域框选的三处 review 问题 - #457
Merged
Merged
Conversation
Address the #455 review: the prompt now gives an area's position inside its cropped screenshot, area offsets track the anchor's own scroll so the outline stays on the marked content, and a drag released over a badge no longer leaves badges unclickable.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修复 #455 合入后 Devin Review 指出的三个 bug：
resolveCommentCropRect移入@pace/core（主进程裁图与格式化共用一份规则）；有截图的区域条目输出- area: W×H at (sx, sy) in its screenshot; (x, y) in the viewport。截图按 CSS 宽度降采样，1 图像像素 = 1 CSS px。area偏移改为锚点滚动内容坐标（加锚点scrollLeft/scrollTop；锚点是文档 scrollingElement 时为 0），保存与渲染共用anchorScroll。suppressClick，徽章吞掉一次 click 后即清除。Test plan
bun run typecheck/lint/build绿（确认resolveCommentCropRect打进out/main/main.js）