Repository navigation
test(e2e): keep annotation input ordered and wait for view bounds to settle - #459
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Annotate mode marks a strict-CSP page…never saw1 comment. Instrumented CI runs showed the Enter keydown reached the overlay with every guard passing, butsaveEditorread an empty textarea:webContents.insertTextandsendInputEventtravel on different channels, so on the CI runner Enter could be handled before the text landed. The helper now types each character as acharinput event, which shares Enter's path and stays ordered.Browser surface loads a page…read the native view width once after a resize and could catch it mid-sync (576 vs 636 on CI). It now polls until the view matches the placeholder within 1px.Test plan
browser-surface.spec.ts --repeat-each=5→ 20/20;bun run typecheck/lint/buildValidate macOS ARM64on this branch: https://github.com/bubbleptr/pace/actions/runs/38074087091 (unit 2106 tests, packaged E2E 35 passed / 2 skipped)