Repository navigation
fix(builtin): preserve leading blank lines in fs.edit when start > 0 - #410
Open
KuljeetSinghXDA wants to merge 1 commit into
Open
KuljeetSinghXDA wants to merge 1 commit into
KuljeetSinghXDA wants to merge 1 commit into
Conversation
frostming
approved these changes
Nov 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
fs.editinsrc/bub/builtin/tools.pywhenstart > 0and the prefix lines are blank (for examplestart=1on a file starting with an empty line"\ny = 2\n").Previously,
if prev:checked truthiness instead ofstart > 0, so an emptyprev("") caused the leading blank line to be silently dropped. Also rejects negativestartvalues withValueErrorinstead of slicing from the end of the file.Verification
uv run ruff check src/bub/builtin/tools.py tests/test_environment.py: passeduv run mypy src:Success: no issues found in 77 source filesuv run pytest tests/test_environment.py -q: 12 passed