Bug 2052696: Fix 002goodperl test failures#165
Merged
Conversation
mrenvoize
requested changes
Jul 10, 2026
Perl files inside templates directories are data in Perl format and not actual Perl code. Adding `use strict` to them and declaring variables with `my` or `our` will break the loader. The core templates folder was already excluded from perl-related tests for this reason, but that exemption was not extended to the templates folder inside extensions. This commit adds comments to each of the currently-affected files explaining that, and extends the exemption to the templates folder in extensions in all of the tests.
mrenvoize
approved these changes
Jul 12, 2026
mrenvoize
left a comment
mrenvoize
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the explanations and follow-up Dave. All looks good to me now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixes a bunch of test failures for extensions that ship disabled with harmony.
Additional info
Test Plan
find extensions -name disabled -maxdepth 2 -exec rm {} \;sh docker/run-tests-in-docker.shpick Option 6