Skip to content

fix(deps): update golang.org/x/crypto - #977

Merged
ashmckenzie merged 1 commit into
mainfrom
fix/x-crypto-vulnerabilities
Sep 4, 2026
Merged

fix(deps): update golang.org/x/crypto#977
ashmckenzie merged 1 commit into
mainfrom
fix/x-crypto-vulnerabilities

Conversation

@ashmckenzie

@ashmckenzie ashmckenzie commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Updates golang.org/x/crypto to v0.56.0 to remediate GO-2026-6354 and GO-2026-6355, which affect the CLI's SSH client path. Because v0.56.0 requires Go 1.26, this also aligns the module minimum with the repository's existing Go 1.26.6 toolchain.

Go 1.25 was EOL'd 19th August 2026.

Changes

  • Upgrade golang.org/x/crypto from v0.55.0 to v0.56.0.
  • Raise the module's minimum Go version from 1.25 to 1.26.

Testing

  • Tests have run locally (with go test ./...)
  • Code is formatted (with go fmt ./...)

mise run vulncheck, mise run lint, and go mod verify also pass.

Disclosures / Credits

Amp diagnosed the linked Buildkite failure, prepared the dependency update, and ran the verification commands under Ash McKenzie's direction.

@ashmckenzie
ashmckenzie requested review from a team as code owners September 4, 2026 04:05
@socket-security

socket-security Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang.org/​x/​crypto@​v0.55.0 ⏵ v0.56.074 +1100100100100

View full report

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module metadata, checksums, and pinned toolchain line up; there’s one stale compatibility note inline.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 25499, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

About buildsworth

Model: gpt-5.6-sol with xhigh thinking.

How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.

Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):

  • L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
  • L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
  • L3 — High risk (auth, migrations, payments, secrets, perf-critical pipeline paths). Human review always required.

Comment thread go.mod
@ashmckenzie ashmckenzie mentioned this pull request Sep 4, 2026
1 task
Amp-Thread-ID: https://ampcode.com/threads/T-01a06a69-e0ff-71ea-8fad-c8e3cdda2237
Co-authored-by: Ash McKenzie <ash.mckenzie@buildkite.com>
@ashmckenzie
ashmckenzie force-pushed the fix/x-crypto-vulnerabilities branch from ff4f2f6 to 3fb8fc4 Compare September 4, 2026 04:12
@ashmckenzie

ashmckenzie commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

The GO-2026-6354 and GO-2026-6355 fixes require a Go 1.25 -> 1.26 bump which isn't ideal but necessary.

@PriyaSudip PriyaSudip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this change :)

@ashmckenzie
ashmckenzie merged commit db4ba3c into main Sep 4, 2026
4 checks passed
@ashmckenzie
ashmckenzie deleted the fix/x-crypto-vulnerabilities branch September 4, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants