Skip to content

Document GitHub issue activity builds - #3157

Closed
lox wants to merge 2 commits into
mainfrom
document-github-issues-events
Closed

Document GitHub issue activity builds#3157
lox wants to merge 2 commits into
mainfrom
document-github-issues-events

Conversation

@lox

@lox lox commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Why

Native GitHub issue builds differ from issue-comment commands and have security and execution semantics that pipeline authors need before opting in. In particular, public authors can trigger builds, workflow code comes from an immutable default-branch commit, and third-party automation can create loops.

Related server support: https://github.com/buildkite/buildkite/pull/32958

What

Document the gated, default-off pipeline setting, supported activity types and unsupported filters, immutable default-branch resolution, rebuild and trigger provenance, public-author trust boundary, quota controls, token recursion behavior, and the distinction from issue-comment commands.

Amp-Thread-ID: https://ampcode.com/threads/T-01a026a4-4f08-71e9-8066-bc3b299ed207
Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
@lox
lox requested a review from a team as a code owner August 26, 2026 07:00
@github-actions github-actions Bot added the pipelines Pull requests that update content related to Pipelines label Aug 26, 2026

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opt-in instructions omit provider and control prerequisites, and the public-author security contract needs the workflow-permission and loop-suppression behavior corrected. I left one smaller environment-reference omission inline.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 21357, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

About buildsworth

Model: gpt-5.6-sol with xhigh thinking.

How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.

Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):

  • L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
  • L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
  • L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.

Comment thread pages/pipelines/source_control/github.md Outdated
Comment thread pages/pipelines/source_control/github.md Outdated
Comment thread pages/pipelines/source_control/github.md Outdated
Comment thread pages/pipelines/source_control/github.md
Amp-Thread-ID: https://ampcode.com/threads/T-01a026a4-4f08-71e9-8066-bc3b299ed207
Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
@buildsworth-bk-app
buildsworth-bk-app Bot dismissed their stale review August 26, 2026 07:24

Previous concerns have been addressed.

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous blocking concerns are fixed. I left one non-blocking environment-reference gap in the existing thread.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 21386, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

lox commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Closing this duplicate in favor of the existing private documentation PR, buildkite/docs-private#2034, which now contains the complete reviewed documentation and will follow the private-to-public docs workflow.

@lox lox closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipelines Pull requests that update content related to Pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants