Repository navigation
fix: wrap a timed event's title over the room its block has #126 - #135
Merged
rathlinus merged 1 commit intoNov 15, 2026
Merged
Conversation
wmcparla
marked this pull request as ready for review
November 13, 2026 20:41
|
I found no problems. CI's Bulwark Warden is an AI assistant and can be wrong. It answers from the docs, the code and earlier issues, and links its sources. |
7 of 14 tasks
Member
|
Thanks, merged. Since #152 went in right after, I made the title wrap only into the room above an event drawn over the block, so no line ends up underneath. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#126: in the day and week grids a timed event's title was always one line (
numberOfLines={1}), however tall its block, so a long title ended in "…" even with room below it. This lets the title wrap over as many lines as the block has room for, after its padding and the start-time line under it (shown from 45 minutes). Short events keep one line.Changes
calendar-time-grid.ts:timedTitleLines(height, withTimeLine, fontScale)counts the lines that fit, never fewer than one. The two line heights (15 and 13) move here as constants so the block's styles and the count share them.EventBlock.tsx:TimedEventBlocktakes the block'sheightas a prop (it was part ofstyle) and sets the title'snumberOfLinesfrom it, with the system text size fromuseWindowDimensions()(line heights grow with it).WeekView.tsx,TimeGridScrollView.tsx: passheightinstead of putting it instyle.calendar-time-grid.test.ts: line counts for 15 min to 2 h blocks, at 1.0 and 1.3 text size.Related issues
Closes #126
Type of change
Checklist
npm run typecheckand there are no errors (native has nolintscript)npm run buildin native; an x86_64 release APK,assembleGithubRelease -PallowDebugSignedRelease=true, builds and runs)locales/) if my changes affect user-facing text (no user-facing text changed)Tests:
npx vitest run: 7107 passed, 163 skipped (the live Stalwart suites), 0 failed.Tested by hand on the Android 16 emulator (1080x2424, 420 dpi), upstream b3b4230 against this branch, with four events seeded on one day: 30 min, 1 h and 2 h with long titles, and 3 h with a short one. Lines counted from the title's height in the view hierarchy; the start time checked to be drawn whole inside its block:
Not tested: iOS (same component;
fontScalefollows Dynamic Type there), a tablet.Screenshots / demo
Notes for reviewers
numberOfLines={1}. The webmail's grids also truncate to one line.🤖 Generated with Claude Code