Repository navigation
feat: let Show Toolbar Labels show or hide the names of the tabs too #128 - #142
Merged
rathlinus merged 1 commit intoNov 15, 2026
Merged
Conversation
Member
|
Thanks, merged. I added the new description for Greek, Nynorsk and Vietnamese, which came to main after you branched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings > Appearance > Show Toolbar Labels now also shows or hides the names under the tab icons (Mail, Calendar, Contacts, Files, Settings), as #128 asks. Until now it only reached the buttons of the message view.
With the names off:
The switch's description now says "Display text labels next to toolbar and navigation icons." in every locale. The translations are machine-made.
Two things that follow from using the existing setting: an organisation policy that locks
showToolbarLabelsnow decides the tab names too, and the accessibility presets that turn the labels on bring the tab names back.Changes
App.tsx:tabBarShowLabelfollowsshowToolbarLabels; icon-only tabs are centred and, on Android, named.src/components/settings/AppearanceSettings.tsx,locales/rn/*.json: the description, in all 29 locales.docs/parity/08-settings-push-i18n-ui.md: where the setting is used.src/components/__tests__/tab-bar-labels-wiring.test.ts(new).Related issues
Closes #128
Type of change
Checklist
npx tsc --noEmit,npx vitest runandnpm run i18n:checkare clean (this repo has no lint or build script)How it was tested
Release builds of this branch, signed in to a test account on a self-hosted Stalwart 1.1.0, with the switch turned off in Settings > Appearance:
Not run on a device: TalkBack and VoiceOver themselves (the names were read from the view hierarchy), an Android tablet, a tab a policy hides or a server lacks, and a right-to-left layout.
Screenshots
The tab bar on the iPhone simulator:
🤖 Generated with Claude Code