Skip to content

feat!: make courses canonical and generate the skill and plugin from one intent list - #4

Merged
bunizao merged 7 commits into
mainfrom
feat/cli-kit-intents
Oct 29, 2026
Merged

bunizao merged 7 commits into
mainfrom
feat/cli-kit-intents

Conversation

@bunizao

@bunizao bunizao commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Moves ontrack onto the shared nouns and intent list from bunizao/cli-kit#1.

  • courses is the canonical noun. units and projects stay as aliases, so every existing command still works. Help, commands --json and the README now say courses. JSON fields are unchanged.
  • One intent list. INTENTS in src/skill.ts is a cli-kit Intent[]. skills generate writes the skill folder skills/ontrack-cli/ (SKILL.md, references/commands.md, agents/openai.yaml) and .claude-plugin/ into the current directory instead of printing SKILL.md, matching moodle. The root SKILL.md is gone; npx skills add and Claude Code both find the folder, and the npm package ships it.
  • The skill says when to use it. Its description ends with "Use when the user names OnTrack or Doubtfire, or asks about portfolio tasks…", quotes how students ask ("did my tutor reply", "mark 2.1P ready for feedback"), and sends Moodle and Ed requests to moodle-cli and edstem-cli. Set, submit and send follow the kit's dry-run, confirm, apply, read-back checklist.
  • Claude Code plugin. Install with claude plugin marketplace add bunizao/ontrack-cli and then claude plugin install ontrack-cli@ontrack-cli. claude plugin validate . --strict passes.
  • Drift checks in npm test. Every intent command must parse against the real command tree, and the committed agent files must match what skills generate would write.

Before merging

  • Depends on @bunizao/cli-kit@^0.7.0, which is now on npm.
  • Merged main in: doctor joins the help groups, the skill table points at doctor --live --cookies when sign-in still fails, and main's three new sign-in rules are condensed into two. The cookie-adoption timing and the DevTools snippet stay in docs/auth.md, since an agent never acts on them.
  • plugin.json carries the package version, so run npm run skill:generate after every version bump or the stale-file test fails.

Not in this PR

  • chats read still marks comments read. The skill states that as an exception to the shared read rule; splitting it out is part of the verb work.
  • Trigger phrases were measured with cli-kit's evals/trigger.mjs (Codex, 3 runs): ontrack-cli fires on 9 or 10 of 10 OnTrack requests depending on the pass, and on no Moodle or Ed request. A request to set up a Doubtfire dev instance still opens this skill, and a "Not for" clause didn't stop it, so the description leaves that out.
  • Error hints and the smoke/golden scripts still say ontrack units …, which works through the alias.

Tests

npm test: 161/161. npm run typecheck passes.

Pin @bunizao/cli-kit to the unreleased feat/shared-nouns commit for the
shared courses noun, intents and agent packaging. Switch to a released
version once cli-kit publishes.
Use SHARED_NOUNS.courses for the top-level command. `ontrack courses` is
now the canonical name; `units` and `projects` stay as aliases, so every
existing invocation keeps working. Help and commands --json name the
command `courses`. JSON output fields are unchanged.
Turn the intent tuples into cli-kit Intent objects and render SKILL.md,
the Claude Code plugin and marketplace manifests and Codex metadata with
agentFiles. `ontrack skills generate` now writes these files into the
current directory instead of printing SKILL.md. Tests check that every
intent command parses against the command tree and that the committed
files are current.
SKILL.md links the command tree in references/commands.md instead of
inlining it.
…k-cli

The description now ends with "Use when …": the OnTrack phrases students
use, and which sibling skill owns Moodle and Ed requests. The skill, its
command reference and Codex metadata move from the repository root to
skills/ontrack-cli/, which npx skills and Claude Code both discover, and
the npm package ships that folder. Mutating intents drop their dry-run
notes, since the kit's checklist now covers dry-run, confirm and read back.
# Conflicts:
#	SKILL.md
#	src/cli-app.ts
#	src/skill.ts
@bunizao
bunizao marked this pull request as ready for review October 29, 2026 09:26
Copilot AI balanced review requested due to automatic review settings October 29, 2026 09:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T09:29:08.406660Z e120633 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-29T09:30:05.612634Z e120633 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bunizao
bunizao merged commit 449514e into main Oct 29, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants