test: subflow fault chain in error-boundary-lab and morph-idm role header precedence - #25
Merged
Conversation
…ader precedence error-boundary-lab gains a three-level SubFlow chain (eb-sf-root -> eb-sf-mid -> eb-sf-leaf): the leaf's HTTP task gets a 400 and faults through a global abort, the mid faults the same way, and the root's global notify rule routes it to r-error-end. SubFlowFaultChainTests pins that the root completes with its incident resolved (history keeps it), which is the preprod "no incident on the main flow" report explained rather than a loss. authorization-chain-lab MorphIdmProviderTests follow the 2026-09-25 decisions: a request role header decides and morph-idm is not asked, the authorize role query parameter behaves like the header, and provider failures resolve to an empty role set that a role-bound deny still refuses. READMEs and the TEST-SCENARIOS index rows record the runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
◈ PR LensNote The title starts with
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two integration-test additions that were on the working tree:
eb-sf-root→eb-sf-mid→eb-sf-leaf, taskeb-http-400-task(MockLab route answering 400) andSubFlowFaultChainTests. The leaf faults through a global abort, the mid faults the same way, and the root's globalnotifyrule routes it tor-error-end. The root completes with its incident resolved (hasActiveIncident=false, the resolved row stays in history). That explains the preprod report "subflow got HTTP 400, main flow ended in error-end, no incident on the main flow": the incident was resolved, not lost.MorphIdmProviderTestsupdated to the 2026-09-25 decisions:roleheader decides, and morph-idm is not asked;authorize'srolequery parameter behaves like the header;READMEs and the
TEST-SCENARIOS.mdrows record the runs and their evidence.Not included (local tool state)
partner.link.json: only an import timestamp changed.credit.link.json: a local link file with an absolute path..vnextstudio/.../account-opening.json: a key from a local run.Test evidence
Recorded in the two READMEs:
SubFlowFaultChainTests: 5/5 green against the locally built runtime.🤖 Generated with Claude Code