Repository navigation
test(task-invocation-lab): CacheAside source-as-task and script-typed keys - #26
Merged
Merged
Conversation
… keys (vnext#1048) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
◈ PR LensNote The title starts with
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourceMapping(InputHandler / OutputHandler);sourceMapping=TilCacheSourceMapping.csx(its output is what gets cached);TilResultProjectionstays the transition mapping and now seesmetadata.CacheHit;til-cache-sourceusesAPI_BASEURLinstead of a literal URLtil:ca:{instanceKey}:{variant}), so a hit can only come from that instanceChanges
core/Tasks/task-invocation-lab/:til-cacheaside-getdata, sixtil-cacheaside-key-*,til-getdata-source)til-cacheasideandtil-cache-sourcebumped to 1.0.1core/Mappings/task-invocation-lab/til-cache-key-{cs,de}.json(REF key bodies)core/Workflows/task-invocation-lab/:$selfcase transitionsTilCacheSourceMapping.csxandTilCacheKey*.csxtests/Core.IntegrationTests/Tests/TaskInvocationLab/CacheAsideSourceAsTaskTests.cs(new); README;TEST-SCENARIOS.mdrowTaskTypeInvocationTests/ResultModelParityTests: the two CacheAside assertions readtilData.payload.value, because the cache now holds the shaped objectTest Plan
8f0383be): CacheAside filter 10/10, TaskInvocationLab 22/23. The 1 red is the pre-existing DaprService parity assertion, see the vnext PR.dotnet build tests/Core.IntegrationTestsNotes
npm run validatefails for object-keycomponents until vnext-schema is released.🤖 Generated with Claude Code