Skip to content

test(task-invocation-lab): CacheAside source-as-task and script-typed keys - #26

Merged
yilmaztayfun merged 1 commit into
masterfrom
feature/cacheaside-source-as-task
Oct 1, 2026
Merged

yilmaztayfun merged 1 commit into
masterfrom
feature/cacheaside-source-as-task

Conversation

@yilmaztayfun

Copy link
Copy Markdown
Contributor

Summary

  • Integration coverage for the CacheAside rework ([bug] CacheAside: sourceMapping InputHandler never runs on cache miss vnext#1048):
    • source runs as a task with sourceMapping (InputHandler / OutputHandler);
    • GetInstanceData source without a static key (the issue's acceptance criterion);
    • all six key kinds (Dynamic Expresso NAT/B64/REF, C# NAT/B64/REF)
  • The existing CacheAside case moves to the new semantics:
    • sourceMapping = TilCacheSourceMapping.csx (its output is what gets cached);
    • TilResultProjection stays the transition mapping and now sees metadata.CacheHit;
    • til-cache-source uses API_BASEURL instead of a literal URL
  • Keys are per instance (til:ca:{instanceKey}:{variant}), so a hit can only come from that instance

Changes

  • core/Tasks/task-invocation-lab/:
    • 8 new tasks (til-cacheaside-getdata, six til-cacheaside-key-*, til-getdata-source)
    • til-cacheaside and til-cache-source bumped to 1.0.1
  • core/Mappings/task-invocation-lab/til-cache-key-{cs,de}.json (REF key bodies)
  • core/Workflows/task-invocation-lab/:
    • workflow 1.0.7 with new $self case transitions
    • new TilCacheSourceMapping.csx and TilCacheKey*.csx
  • tests/Core.IntegrationTests/Tests/TaskInvocationLab/CacheAsideSourceAsTaskTests.cs (new); README; TEST-SCENARIOS.md row
  • TaskTypeInvocationTests / ResultModelParityTests: the two CacheAside assertions read tilData.payload.value, because the cache now holds the shaped object

Test Plan

Notes

🤖 Generated with Claude Code

… keys (vnext#1048)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yilmaztayfun
yilmaztayfun requested review from a team October 1, 2026 11:08
@coldtea-pr-lens

Copy link
Copy Markdown

◈ PR Lens

Note

The title starts with test(task-invocation-lab):, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ead4e1ec-c755-4f10-a22e-07a9e1e811e4

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yilmaztayfun yilmaztayfun self-assigned this Oct 1, 2026
@yilmaztayfun
yilmaztayfun merged commit a48f9bc into master Oct 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant