Repository navigation
test(error-boundary-lab): pin context.Incident inside a handled subflow fault - #28
Merged
Merged
Conversation
…ow fault eb-sf-root's boundary transition (r-has-error) and its error end's OnEntry now run an incident probe mapping that records what context.Incident shows. Before the runtime fix both read hasActiveIncident = true with no active incident and a count of 0; with it they see the leaf's incident (task, status 400, Notify). SubFlowFaultChainTests asserts both slots. The lab moves to 1.2.0 (a published version is immutable). README and the TEST-SCENARIOS row record the defect and the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
◈ PR LensNote The title starts with
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eb-sf-root: its boundary transition (r-has-error) and ther-error-endOnEntry each run a mapping that writes whatcontext.Incidentshows into instance data.SubFlowFaultChainTests.AMappingInsideTheBoundaryHandling_SeesTheSubFlowIncidentasserts both slots see the leaf's incident: taskeb-http-400-task, status 400,Notify, count 1.fix/script-context-incident-snapshot). Before that fix, a mapping in either slot sawhasActiveIncident: truebutActiveIncident: nulland a count of 0. That is the preprod report: the onboarding developer could not branch on the subflow's failure.Changes
core/Workflows/error-boundary-lab/src/EbIncidentProbeMapping.csx: the probe mapping.core/Tasks/error-boundary-lab/eb-incident-probe-task{,-2}.json: one script-task component per slot. The task journal key is (transition, task), so the same component can't be used twice in one transition.build-error-boundary-lab.py: wires the probes and bumps the lab to 1.2.0, because a published version is immutable. The regenerated JSON follows.TEST-SCENARIOS.mdrow record the defect and the fix.Test Plan
wf domain use core && wf updateVNEXT_BASE_URL=http://localhost:4201 dotnet test --filter "FullyQualifiedName~ErrorBoundaryLab"Integration test evidence
Tests/ErrorBoundaryLab(--filter FullyQualifiedName~ErrorBoundaryLab)fix/script-context-incident-snapshot@866d4809,http://localhost:4201(run-docker.sh up core)SecuredIncidentsTests.WithoutTheRole_…Refuse: it still expects 403, but vnext #1027 moved queryRoles enforcement out of the runtime, so the expectation is stale and unrelated to this change.activeIncidentPresent: false,totalIncidentCount: 0).Cwith one resolvedNotifyincident; mid and leafFwith one openAbortincident each, all with status 400 and taskeb-http-400-task.TEST-SCENARIOS.mdrow updated: yesNotes
🤖 Generated with Claude Code